Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add F401 (unused imports) rule to ruff config #3026

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add F401 (unused imports) rule to ruff config #3026

merged 1 commit into from
Nov 25, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 25, 2024 •
edited
Loading

This is just my suggestion. so please add your opinion if and why you think this is not a great idea.

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Sep 25, 2024
@johannaengland johannaengland self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 12.93s
✅ PYTHON ruff 988 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Test results

    9 files      9 suites   8m 18s ⏱️
2 143 tests 2 143 ✅ 0 💤 0 ❌
4 025 runs  4 025 ✅ 0 💤 0 ❌

Results for commit 81de196.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (8b0e5bd) to head (81de196).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3026   +/-   ##
=======================================
  Coverage   60.40%   60.40%           
=======================================
  Files         605      605           
  Lines       43685    43685           
  Branches       48       48           
=======================================
  Hits        26388    26388           
  Misses      17285    17285           
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

This was referenced Sep 25, 2024
Merged
Merged
@johannaengland johannaengland changed the base branch from master to cleanup/add-noqa-to-necessary-unused-imports September 27, 2024 09:06
@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from f4eaae2 to 2a2c093 Compare September 27, 2024 09:07
@johannaengland johannaengland force-pushed the ruff/add-unused-imports-rule branch from d8144b6 to 14a50e3 Compare September 27, 2024 09:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch 2 times, most recently from e0fed99 to afbe765 Compare November 22, 2024 09:41
Base automatically changed from cleanup/add-noqa-to-necessary-unused-imports to master November 22, 2024 09:51
@johannaengland johannaengland force-pushed the ruff/add-unused-imports-rule branch from 14a50e3 to a2d2618 Compare November 22, 2024 12:14
@johannaengland johannaengland force-pushed the ruff/add-unused-imports-rule branch from a2d2618 to 81de196 Compare November 25, 2024 12:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johannaengland johannaengland merged commit 81e87de into master Nov 25, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the ruff/add-unused-imports-rule branch November 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
discussion Requires developer feedback/discussion before implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannaengland @lunkwill42